SNOW-976702 : Add timeseries agg dataframe function. #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-rsureshbabu
changed the base branch from
main
to
rsureshbabu-SNOW-SNOW-976701-movingagg
sfc-gh-rsureshbabu
requested review from
sfc-gh-mkeller,
sfc-gh-yixie,
sfc-gh-wezhou and
sfc-gh-tbao
and removed request for
a team
Base automatically changed from
rsureshbabu-SNOW-SNOW-976701-movingagg
to
main
January 25, 2024 00:15
sfc-gh-wezhou
approved these changes
Jan 29, 2024
Comment on lines
+456
to
+457
| sliding_point_col = "sliding_point" | ||
|
|
There was a problem hiding this comment.
would this overwrite sliding_point if original df has this column? I would suggest using randomized name - see random_table_name in utils.py
There was a problem hiding this comment.
This is not a temporary column. I am not sure about generating a random name for an output column. This will make it hard to write queries based on this column. We could put a contact suffix/prefix to the name. That can bring down the probability of collision. Say "sp_gen_sliding_point". wdyt ?
sfc-gh-aalam
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
SNOW-976702
The Pr is adding the time series aggregation function as proposed in https://docs.google.com/document/d/14J5lr_a3fE1xeU-YzKWdeduBdC_035sry11lJUjjkT8/edit
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.