SNOW-1016709: Add local testing support for STRIP_NULL_VALUE #1222
Conversation
sfc-gh-jrose
requested review from
sfc-gh-yixie,
sfc-gh-aling and
sfc-gh-stan
CHANGELOG.md
Outdated
| @@ -16,6 +16,8 @@ | |||
| - `array_except` | |||
| - `create_map` | |||
| - `sign`/`signum` | |||
| - Added support for the following local testing functions: | |||
There was a problem hiding this comment.
This should move to a new release.
| def mock_strip_null_value(expr: ColumnEmulator): | ||
| return ColumnEmulator( | ||
| [None if x == "null" else x for x in expr], sf_type=expr.sf_type | ||
| ) |
There was a problem hiding this comment.
I feel like nullability could be different than the input column?
There was a problem hiding this comment.
same question about the nullability of the ColumnType, is the current backend behavior always returning true?
There was a problem hiding this comment.
Experimentally it appears to always return a column that is nullable. I wonder if it would be useful to create a test that runs both the normal version and local testing version of a test and then ensures they return the same result.
There was a problem hiding this comment.
Tests outside tests/mock that are marked with pytest.mark.localtest are run against both a live connection and a local testing connection.
sfc-gh-jrose
force-pushed
the
jrose_snow_1016709_add_STRIP_NULL_VALUE
branch
from
892295f to
32a0861
Compare
| def mock_strip_null_value(expr: ColumnEmulator): | ||
| return ColumnEmulator( | ||
| [None if x == "null" else x for x in expr], sf_type=expr.sf_type | ||
| ) |
There was a problem hiding this comment.
same question about the nullability of the ColumnType, is the current backend behavior always returning true?
sfc-gh-jrose
force-pushed
the
jrose_snow_1016709_add_STRIP_NULL_VALUE
branch
from
470950c to
a3e34fc
Compare
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #1016709
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds local testing support for STRIP_NULL_VALUE.
Question for reviewers:
Is STRIP_NULL_VALUE always called with a value column or should it be able to walk a json object and replace all instances of 'null'?