Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1023214: Support date_part argument in last_day #1224

Merged
merged 8 commits into from
Jan 31, 2024
Merged

SNOW-1023214: Support date_part argument in last_day #1224

merged 8 commits into from
Jan 31, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1023214

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds support for the optional date_part argument for the Snowflake function last_day. See the SQL documentation here: https://docs.snowflake.com/en/sql-reference/functions/last_day

@sfc-gh-nkrishna sfc-gh-nkrishna requested a review from a team as a code owner January 30, 2024 16:29
sfc-gh-stan
sfc-gh-stan reviewed Jan 31, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-nkrishna
address comments
1f36a3e 
Signed-off-by: Naren Krishna <[email protected]>
sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-stan sfc-gh-stan enabled auto-merge (squash) January 31, 2024 19:43
@sfc-gh-stan sfc-gh-stan merged commit d1120ad into main Jan 31, 2024
55 checks passed
@sfc-gh-stan sfc-gh-stan deleted the last_day_part branch January 31, 2024 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-nkrishna @sfc-gh-stan @sfc-gh-evandenberg