Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1032642: Fix table name truncation in local testings error #1230

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #1032642

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

The below error message assumes that tables are quoted which is not always the case.

@sfc-gh-jrose sfc-gh-jrose self-assigned this Jan 31, 2024
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner January 31, 2024 20:12
CHANGELOG.md Outdated
@@ -45,6 +45,7 @@
- Fixed a bug in `Session.create_dataframe` that the non-nullable field in a schema is not respected for boolean type. Note that this fix is only effective when the user has the privilege to create a temp table.
- Fixed a bug in SQL simplifier where non-select statements in `session.sql` dropped a SQL query when used with `limit()`.
- Fixed a bug that raised an exception when session parameter `ERROR_ON_NONDETERMINISTIC_UPDATE` is true.
- Fixed a bug that truncated table names in error messages while running a plan with local testing enabled.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry should be under a new release with TBD release date.

@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_1032642_fix_error_msg_truncations branch from 16c3a7f to d805d86 Compare February 1, 2024 19:48
@sfc-gh-jrose sfc-gh-jrose merged commit c759376 into main Feb 2, 2024
57 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1032642_fix_error_msg_truncations branch February 2, 2024 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants