Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1016748 Fixed a bug that Session.range returns empty result when… #1240

Merged
merged 2 commits into from
Feb 7, 2024
Merged

SNOW-1016748 Fixed a bug that Session.range returns empty result when… #1240

merged 2 commits into from
Feb 7, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Feb 7, 2024 •
edited
Loading

… the range is large

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1016748 Fixed a bug that Session.range returns empty result when the range is large

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Fix a bug that is triggered by overflow when a numpy int multiply with a python int.

@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner February 7, 2024 01:20
sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-jdu sfc-gh-jdu merged commit 24a7ae3 into main Feb 7, 2024
55 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the fix-range-overflow-1016748 branch February 7, 2024 23:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-azhan @sfc-gh-jdu @sfc-gh-stan @sfc-gh-evandenberg