Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.12.1 #1243

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Release v1.12.1 #1243

merged 6 commits into from
Feb 8, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

frederiksteiner and others added 3 commits February 7, 2024 11:53
* Added fix for integer column with None values

* Rename test name

* Added changelog

---------

Co-authored-by: Frederik Steiner <[email protected]>
* use split_blocks=True by default

* changelog updates

* more details in changelog

* fix grammar

* fix changelog

* revert to minimal changelog
CHANGELOG.md Outdated

### Bug Fixes

- Fixed a bug in `DataFrame.to_pandas` that caused an error when evaluating on a dataframe with an IntergerType column with null values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataframe -> DataFrame

CHANGELOG.md Outdated

### New Features

- Use `split_blocks=True` by default during `to_pandas` conversion for optimal memory allocation. This parameter is passed to `pyarrow.Table.to_pandas` that enables `PyArrow` to split the memory allocation into smaller, more manageable blocks instead of allocating a single contiguous block thus giving better memory management when dealing with larger datasets.
Copy link
Contributor

@sfc-gh-mabrennan sfc-gh-mabrennan Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing this:

- Use `split_blocks=True` by default during `to_pandas` conversion for optimal memory allocation. This parameter is passed to `pyarrow.Table.to_pandas` that enables `PyArrow` to split the memory allocation into smaller, more manageable blocks instead of allocating a single contiguous block thus giving better memory management when dealing with larger datasets.

to this:

- Use `split_blocks=True` by default during `to_pandas` conversion, for optimal memory allocation. This parameter is passed to `pyarrow.Table.to_pandas`, which enables `PyArrow` to split the memory allocation into smaller, more manageable blocks instead of allocating a single contiguous block. This results in better memory management when dealing with larger datasets.

Copy link
Contributor

@sfc-gh-mabrennan sfc-gh-mabrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made 2 small suggestions. Thank you.

@@ -1,5 +1,15 @@
# Release History

## 1.12.1 (2024-02-08)

### New Features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't expose new APIs / features to users so "Improvements" might be better than "New Features".

@sfc-gh-aalam
Copy link
Contributor Author

Manually ran merge gates here: https://github.com/snowflakedb/snowpark-python/actions/runs/7822307495

@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) February 8, 2024 22:47
@sfc-gh-aalam sfc-gh-aalam merged commit 26f561a into main Feb 8, 2024
57 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the changelog-update-post-1.12.1-release branch February 8, 2024 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants