SNOW-1043119: Add upper/lower/length/initcap support to local testing #1246
+132
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-stan
reviewed
Feb 15, 2024
| @@ -3256,17 +3257,71 @@ def test_ascii(session, col_B): | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("col_A", ["A", col("A")]) | |||
There was a problem hiding this comment.
NIT: I feel like it's not necessary to test "A" vs "col("A") 🤷♀️
sfc-gh-stan
approved these changes
Feb 15, 2024
sfc-gh-aling
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #1043119
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds support for string operations upper, lower, length, and initcap to local testing. I also added additional testing examples to check a few more cases that I wanted.