Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1161403 Replaced all pandas text to lowercase #1277

Merged
merged 2 commits into from
Feb 28, 2024
Merged

SNOW-1161403 Replaced all pandas text to lowercase #1277

merged 2 commits into from
Feb 28, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Feb 27, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1161403 Replaced all pandas text to lowercase

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Make it consistent with pandas where itself and related projects all use lowercase for pandas, e.g., "pandas API on spark" and "cuDF pandas accelerator mode"

@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review February 27, 2024 23:50
@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner February 27, 2024 23:50
sfc-gh-stan
sfc-gh-stan reviewed Feb 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-aalam sfc-gh-aalam merged commit eb5c3e0 into main Feb 28, 2024
56 of 57 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the azhan-lower-pandas-1161403 branch February 28, 2024 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-azhan @sfc-gh-stan @sfc-gh-aalam