Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1269037: [Local Testing] Add support for NaT and NaN values #1393

Merged
merged 8 commits into from
Apr 29, 2024
Merged

SNOW-1269037: [Local Testing] Add support for NaT and NaN values #1393

merged 8 commits into from
Apr 29, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1269037

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds support for the None like values NaN (not a number) and NaT (not a time) to the schema inference function for local testing.

@sfc-gh-sghosh sfc-gh-sghosh mentioned this pull request Apr 17, 2024
Closed
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review April 23, 2024 19:50
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner April 23, 2024 19:50
sfc-gh-stan
sfc-gh-stan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, please update the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
src/snowflake/snowpark/_internal/type_utils.py
@@ -264,6 +264,15 @@ def convert_sp_to_sf_type(datatype: DataType) -> str:
datetime.time: TimeType,
bytes: BinaryType,
}
if installed_pandas:
Copy link
Collaborator

@sfc-gh-stan sfc-gh-stan Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant fix :chef_kiss:

sfc-gh-aling
sfc-gh-aling reviewed Apr 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-stan sfc-gh-stan added the local testing Local Testing issues/PRs label Apr 29, 2024
@sfc-gh-jrose sfc-gh-jrose merged commit ce2008e into main Apr 29, 2024
25 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1269037_nat_support branch April 29, 2024 23:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
local testing Local Testing issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jrose @sfc-gh-stan @sfc-gh-aling