Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1227759: Fix the type annotation of save_as_table #1395

Merged
merged 1 commit into from
Apr 18, 2024
Merged

SNOW-1227759: Fix the type annotation of save_as_table #1395

merged 1 commit into from
Apr 18, 2024

Conversation

sfc-gh-jdu
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1227759: ambiguous overload typing causing typing error false positives with DataFrameWriter.save_as_table() #1296

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-jdu sfc-gh-jdu requested a review from a team as a code owner April 17, 2024 17:37
@sfc-gh-jdu sfc-gh-jdu added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Apr 17, 2024
@sfc-gh-jdu sfc-gh-jdu enabled auto-merge (squash) April 18, 2024 17:53
@sfc-gh-jdu sfc-gh-jdu merged commit 30a77e7 into main Apr 18, 2024
21 of 22 checks passed
@sfc-gh-jdu sfc-gh-jdu deleted the jdu-SNOW-1227759-write-overload branch April 18, 2024 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie approved these changes

@sfc-gh-stan sfc-gh-stan Awaiting requested review from sfc-gh-stan sfc-gh-stan is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
3 participants
@sfc-gh-jdu @sfc-gh-yixie @sfc-gh-aling