Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1063716: [Local Testing] Add support for get #1431

Merged
merged 7 commits into from
Apr 30, 2024
Merged

SNOW-1063716: [Local Testing] Add support for get #1431

merged 7 commits into from
Apr 30, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #1063716

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds support for the get function to local testing.

@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review April 26, 2024 16:20
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner April 26, 2024 16:20
@sfc-gh-stan sfc-gh-stan added the local testing Local Testing issues/PRs label Apr 29, 2024
@sfc-gh-jrose sfc-gh-jrose merged commit c470057 into main Apr 30, 2024
25 of 26 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1063716_local_testing_get_support branch April 30, 2024 03:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
local testing Local Testing issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jrose @sfc-gh-stan @sfc-gh-aling