-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1344848: Suppress dynamic pivot warnings #1434
SNOW-1344848: Suppress dynamic pivot warnings #1434
Conversation
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
I removed @sfc-gh-lmukhopadhyay because she's OOO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I want to wait for pandas team reviewing this since we don't have tons of knowledge of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too complicated of a solution for a minor problem.
src/snowflake/snowpark/modin/plugin/_internal/ordered_dataframe.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I agree with @sfc-gh-jkew's comment - think there may be an easier solution here.
src/snowflake/snowpark/modin/plugin/_internal/ordered_dataframe.py
Outdated
Show resolved
Hide resolved
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to also surpress the warning when the user (1) imports Snowpark pandas but doesn't do anything and (2)uses dynamic pivot directly from Snowpark Python API. But I understand the code will be much more complicated to address this specific case, in the future we should work out a way to generalize this solution for if Snowpark Pandas uses an experimental/pre-GA public API from Snowpark Python, the warning should be surpressed
.
Sure, if this comes up at least twice again, we might want to add something like the log filter I added earlier to generalize the warning suppression here. |
LGTM |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1344848
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Stop warning the user about our internal usage of private preview
dynamic pivot features. The user should have already been warned that
Snowpark pandas is in public or private preview. They very likely don't
know or care that we are using Snowpark DataFrame pivot() internally,
let alone that we are using private preview features of Snowpark
Python.
I'm not adding a changelog note because we haven't released a version of
Snowpark Python with this bug yet.