SNOW-1316977: Remove fallbacks and raise not implemented error #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1316977-fallback
branch
from
c4347f4 to
8b55d36
Compare
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1316977-fallback
branch
2 times, most recently
from
5f2c209 to
df2ae49
Compare
sfc-gh-nkumar
changed the title
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1316977-fallback
branch
3 times, most recently
from
4093765 to
4247a8e
Compare
sfc-gh-nkumar
added
the
NO-CHANGELOG-UPDATES
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Show resolved
Hide resolved
sfc-gh-helmeleegy
approved these changes
Apr 29, 2024
sfc-gh-lmukhopadhyay
requested changes
Apr 29, 2024
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1316977-fallback
branch
from
4247a8e to
d9ff0d5
Compare
sfc-gh-lmukhopadhyay
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1316977
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Remove fallback for all dataframe and series APIs. This list is primarily driven from https://docs.google.com/document/d/1uMwNgLqFhtoAFeEj59XjR3uKQ77QjA84aTmv8Erbvw0/edit#heading=h.qhdbmdhgqdh5. There still might be more fallback which are not documented. This will be cleaned up in https://snowflakecomputing.atlassian.net/browse/SNOW-1347394
NOTE: I have kept the existing tests mostly unmodified even though there is redundancy. This can be useful when we implement these APIs.
NOTE: This also require updates in docs/*supported.rst files. These files are not yet ported from snowpandas. So will do a follow up PR to update the docs.