SNOW-1348403: Fix the SNOW issue template in pull request template. #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a JIRA template that will make GitHub hyperlink to a SNOW- issue if developers fill in the issue number.
sfc-gh-mvashishtha
added
NO-CHANGELOG-UPDATES
sfc-gh-mvashishtha
requested review from
sfc-gh-rdurrani,
sfc-gh-joshi,
sfc-gh-yuwang,
sfc-gh-aalam and
sfc-gh-jrose
sfc-gh-jkew
reviewed
Apr 26, 2024
| @@ -2,7 +2,7 @@ Please answer these questions before submitting your pull requests. Thanks! | |||
|
|
|||
| 1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR. | |||
|
|
|||
| Fixes #NNNN | |||
| Fixes SNOW-NNNNNNN | |||
There was a problem hiding this comment.
This this is a public repository, I think we want it to be generic so github issues can be referenced.
There was a problem hiding this comment.
I believe the repo has a bot that automatically generates JIRAs for every filed ticket.
noloerino
approved these changes
Apr 26, 2024
sfc-gh-joshi
approved these changes
Apr 26, 2024
sfc-gh-vbudati
approved these changes
Apr 26, 2024
sfc-gh-mvashishtha
deleted the
mvashishtha/SNOW-1348403/fix-snow-issue-template-in-pr-template
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1348403
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Use a JIRA template that will make GitHub hyperlink to a SNOW- issue if developers fill in the issue number.