Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1297195] Add tox to daily jenkins job, fix tox.ini. #1442

Merged
merged 6 commits into from
Apr 29, 2024
Merged

[SNOW-1297195] Add tox to daily jenkins job, fix tox.ini. #1442

merged 6 commits into from
Apr 29, 2024

Conversation

sfc-gh-lspiegelberg
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg commented Apr 26, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1297195

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    There were a few issues which prevent the daily snowpark pandas API jenkins job to run successfully:

    • tox.ini had MODIN_PYTEST_NO_COV_CMD missing
    • the jenkins invocation script requires tox to be installed
    • the tox_install_cmd.sh was using sh, but should be bash and variables were not defined.
      this PR addresses these issues.

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Apr 26, 2024
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg changed the title [DRAFT] add tox install to jenkins script [SNOW-1297195] Add tox to daily jenkins job, fix tox.ini. Apr 26, 2024
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg marked this pull request as ready for review April 26, 2024 21:43
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg requested review from a team as code owners April 26, 2024 21:43
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg enabled auto-merge (squash) April 26, 2024 22:02
sfc-gh-azhan
sfc-gh-azhan reviewed Apr 26, 2024
View reviewed changes
tox.ini Show resolved Hide resolved
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg merged commit 2accbfc into main Apr 29, 2024
25 of 26 checks passed
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg deleted the ls-SNOW-1297195-followup branch April 29, 2024 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan left review comments

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@noloerino noloerino noloerino approved these changes

@sfc-gh-mvashishtha sfc-gh-mvashishtha Awaiting requested review from sfc-gh-mvashishtha sfc-gh-mvashishtha was automatically assigned from snowflakedb/snowpandas

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-sfan sfc-gh-sfan Awaiting requested review from sfc-gh-sfan sfc-gh-sfan is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-lspiegelberg @noloerino @sfc-gh-azhan @sfc-gh-nkrishna @sfc-gh-joshi