SNOW-1347387 Raise not implemented error for Series.dt.* methods #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1347387-fallback-dt
branch
2 times, most recently
from
20e0e50 to
1be345a
Compare
sfc-gh-nkumar
added
NO-CHANGELOG-UPDATES
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1347387-fallback-dt
branch
from
1be345a to
a2c22b8
Compare
sfc-gh-jkew
approved these changes
Apr 30, 2024
sfc-gh-helmeleegy
approved these changes
Apr 30, 2024
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1347387-fallback-dt
branch
from
a2c22b8 to
622328e
Compare
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1347387-fallback-dt
branch
3 times, most recently
from
bb7332e to
1632074
Compare
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1347387-fallback-dt
branch
from
1632074 to
2772986
Compare
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1347387-fallback-dt
branch
from
2772986 to
e6b6e90
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1347387
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Raise not implemented error for Series.dt.* methods instead of falling back to native pandas.
NOTE: I have kept the existing tests mostly unmodified even though there is redundancy. This can be useful when we implement these APIs.
NOTE: This also require updates in docs/*supported.rst files. These files are not yet ported from snowpandas. So will do a follow up PR to update the docs.