SNOW-1348886: Bugfix: AssertError in sort_values after indexing #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-nkumar
added
NO-CHANGELOG-UPDATES
sfc-gh-vbudati
approved these changes
Apr 29, 2024
src/snowflake/snowpark/modin/plugin/_internal/ordered_dataframe.py
Outdated
Show resolved
Hide resolved
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1348886-bugfix-sort-values
branch
from
b7b88ee to
9785b46
Compare
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-1348886-bugfix-sort-values
branch
from
9785b46 to
a2537ed
Compare
sfc-gh-nkrishna
approved these changes
Apr 30, 2024
|
nice work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1348886
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Following steps result in AssertionError: row count column "row_count" not found in ['"row_position"', '"PRICE"']
df = pd.read_snowflake("LINEITEM")
print(df)
df["PRICE"].sort_values(ascending=True)
Root cause: in ordered_dataframe.sort method we are passing row_count column to new ordered dataframe but didn't include row_count column in projection.