-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lnino/array_remove #2372
base: main
Are you sure you want to change the base?
Fix lnino/array_remove #2372
Conversation
94869eb
to
e12661b
Compare
de82739
to
3a8fceb
Compare
7f84835
to
f43d9da
Compare
a23d90d
to
85a1b00
Compare
b9e4d08
to
593dfb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other changes look good. some of the changes are already covered in doctest so adding so many tests cases is not necessary but it doesn't hurt too much either :)
expected = session.createDataFrame( | ||
[ | ||
Row("[\n 1,\n 2,\n 3\n]"), | ||
Row("[]"), | ||
], | ||
["data"], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not: creating a dataframe here (and other updates below) is not necessary
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SIT-1755
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Cast the element parameter to VARIANT if it is a string to ensure correct handling by the array_remove function. This prevents type mismatch issues that could occur when the input is not already of the VARIANT type.