[SNOW-1566363] Add telemetry for new compilation stage #2394
+130
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yzou
force-pushed
the
yzou-SNOW-1566363-compilation-telemetry
branch
from
ebe1e26
to
786b795
Compare
sfc-gh-yzou
added
the
NO-CHANGELOG-UPDATES
sfc-gh-yzou
requested review from
sfc-gh-yixie,
sfc-gh-aling and
sfc-gh-yuwang
sfc-gh-aalam
approved these changes
Oct 3, 2024
Comment on lines
80
to
83
| QUERY_PLAN_HEIGHT = "query_plan_height" | ||
| QUERY_PLAN_NUM_SELECTS_WITH_COMPLEXITY_MERGED = ( | ||
| "query_plan_num_selects_with_complexity_merged" | ||
| ) |
There was a problem hiding this comment.
should we move these to _internal/compiler/telemetry_constants.py?
There was a problem hiding this comment.
@sfc-gh-aalam do you mean move all QUERY_PLAN_HEIGHT, QUERY_PLAN_NUM_SELECTS_WITH_COMPLEXITY_MERGED, QUERY_PLAN_NUM_DUPLICATE_NODES, QUERY_PLAN_COMPLEXITY all to telemetry_constants.py?
or just QUERY_PLAN_NUM_SELECTS_WITH_COMPLEXITY_MERGED. i felt if we want to move, probably be better to move all of them, instead of just wan , which seems little bit wired
There was a problem hiding this comment.
actually, let's move all those over, even though those telemetry are not just issued during the compilation stage, but the information is used by the compilation stage,
sfc-gh-jdu
approved these changes
Oct 4, 2024
sfc-gh-yzou
force-pushed
the
yzou-SNOW-1566363-compilation-telemetry
branch
from
1818bfc
to
f1d4b34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
SNOW-1566363
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
add status for number of selectStatement with complexity merged
2.add status for number of cte created during repeated subquery elimination