Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1805840: Augment telemetry with method_call_count #2804

Merged
merged 18 commits into from
Jan 14, 2025
Merged

SNOW-1805840: Augment telemetry with method_call_count #2804

merged 18 commits into from
Jan 14, 2025
+141 −2

Conversation

sfc-gh-lmukhopadhyay
Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay commented Dec 20, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1805840

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

Adding method_call_count which is the # of times a pandas API method has been called.
See more info in the interchange protocol design doc here: https://docs.google.com/document/d/1EfqQwejVbF5_36hnOP-ap0t3NaCWmDz62iAcR0PtX20/edit?tab=t.0#heading=h.4uu48icmuq7z

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Dec 20, 2024
@sfc-gh-lmukhopadhyay
update changelog
733f4b0 
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
@sfc-gh-lmukhopadhyay
fix telem tests
ed2bd25 
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay marked this pull request as ready for review December 20, 2024 23:40
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay requested a review from a team as a code owner December 20, 2024 23:40
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title SNOW-1805840: Augment telemetry with method_call_count and interchange_call_count SNOW-1805840: Augment telemetry with method_call_count Jan 6, 2025
sfc-gh-mvashishtha
sfc-gh-mvashishtha approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Jan 7, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sfc-gh-helmeleegy
sfc-gh-helmeleegy reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is talking about introducing interchange_call_count, which I don't think is accurate -- there is no such variable/field.

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Just left a few nits/questions.

@sfc-gh-lmukhopadhyay
add test for multiple funcs on same qc
05204b0 
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay merged commit 80d722e into main Jan 14, 2025
44 checks passed
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay deleted the lmukhopadhyay-SNOW-1805840-telem-call-count branch January 14, 2025 04:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi left review comments

@sfc-gh-jjiao sfc-gh-jjiao sfc-gh-jjiao approved these changes

@sfc-gh-mvashishtha sfc-gh-mvashishtha sfc-gh-mvashishtha approved these changes

@sfc-gh-rdurrani sfc-gh-rdurrani Awaiting requested review from sfc-gh-rdurrani sfc-gh-rdurrani is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-lmukhopadhyay @sfc-gh-mvashishtha @sfc-gh-joshi @sfc-gh-helmeleegy @sfc-gh-jjiao