Upgrade common-streams to 0.8.0-M4 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzhanunlu
force-pushed
the
cs-0.8.0-M4
branch
3 times, most recently
from
1ec1e0b
to
263a31c
Compare
oguzhanunlu
force-pushed
the
cs-0.8.0-M4
branch
from
263a31c
to
76680f6
Compare
istreeter
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Neither your commit nor your PR has a description. Even though you are just bumping a library, this is a very important library change that directly affects the behaviour of the loader. See #381 or #371 for examples of where common-streams was bumped to a newer version, and the PR has a nice description to explain the impact of the change.
modules/core/src/main/scala/com.snowplowanalytics.snowplow.bigquery/Environment.scala
Outdated
Show resolved
Hide resolved
|
@istreeter , I just added a detailed PR description and pushed a new commit to address your comments, could you have another look please? |
istreeter
reviewed
Sep 16, 2024
istreeter
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to M2, common-streams 0.8.0-M4 brings the following changes:
_if they start with a digit.The new http client has a single configuration field
maxConnectionsPerServerthat should be configurable in bq loader, hence we introduce a new top-level config,httpcontainingmaxConnectionsPerServeronly for the moment.