Collector 3.x and Enrich 4.x #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondzix
force-pushed
the
micro_http4s
branch
from
ae39f84 to
20c954a
Compare
pondzix
force-pushed
the
micro_http4s
branch
from
20c954a to
d6f241f
Compare
peel
approved these changes
Feb 15, 2024
| } yield () | ||
| } | ||
|
|
||
| private def setupSSLContext(): IO[Unit] = IO { |
There was a problem hiding this comment.
I've always found java keystores a bit pain to generate and manage. There is nothing wrong with this approach but I wonder if one day we should add pem support to ease on the user-side of SSL support. It shouldn't be big of a deal. Given you're AFK I can have a stab at it with the subsequent try work.
stanch
reviewed
Feb 16, 2024
|
|
||
| object MicroAdapterRegistry { | ||
|
|
||
| private val adaptersSchemas = AdaptersSchemas( |
There was a problem hiding this comment.
Would this not be a problem if we update this inside Enrich (which can be done with configuration now) and it does not match?
There was a problem hiding this comment.
I changed it to load schemas from defaults provided by Enrich instead of hardcoded values in micro 0d64df1
|
Part of #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New collector and enrich versions mean:
To be consistent with other Snowplow applications, this commit also brings small improvements to configuration loading. Just like collector configuration, iglu resolver and all enrichments support HOCON configuration format.
As collector 3.x is on scala 2.13 and enrich 2.12, it was easier to cross compile collector to 2.12 than upgrade enrich to 2.13. That's why micro uses collector from this branch -> https://github.com/snowplow/stream-collector/tree/3.1.0_cross_scala_2.12 and is based on scala 2.12