Fix/snowflake varchar cols #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnessnowplow
force-pushed
the
fix/snowflake_varchar_cols
branch
from
59f6552 to
510baa4
Compare
ilias1111
reviewed
Dec 18, 2024
web/v1/snowflake/sql-runner/playbooks/standard/99-migrations/1.0.1-migration.yml.tmpl
Show resolved
Hide resolved
jbeemster
reviewed
Dec 19, 2024
web/v1/snowflake/sql-runner/sql/standard/99-migrations/1.0.3-migration/alter-tables.sql
Outdated
Show resolved
Hide resolved
ilias1111
approved these changes
Jan 2, 2025
agnessnowplow
force-pushed
the
fix/snowflake_varchar_cols
branch
from
b6ae334 to
8f31ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is essentially two releases in one as both handle the same: making sure that regardless if any atomic varchar field that currently has a fixed length changes to varchar it won't break the data model.
It affects Snowflake users that want to use the Snowflake Streaming Loader, which allows for such changes.
Snowflake Mobile Version 1.1.1 (2025-01-08)
Snowflake Mobile: Remove length limits from varchar fields
Snowflake Web Version 1.0.3 (2025-01-08)
Snowflake Web: Remove length limits from varchar fields
Migration Guide
Please run the migration playbooks first, as part of the upgrade to prepare existing model tables for the changes.
Alternatively, copy the scripts, replace the placeholders and execute them in your sql editor of choice before upgrading and running the model for the first time.
Developer Notes
E2E tests run successfully for both models as well as the separate migration playbooks:
sql-runner -playbook "sql-runner/playbooks/standard/99-migrations/1.0.3-migration.yml" -sqlroot "sql-runner/sql"
sql-runner -playbook "sql-runner/playbooks/standard/99-migrations/1.1.1-migration.yml" -sqlroot "sql-runner/sql"