Skip to content

Commit

Permalink
updated macro to solve issue (#19)
Browse files Browse the repository at this point in the history
Adjustment to updated return_limits_from_model macro
  • Loading branch information
OscarSnowPlow authored Oct 11, 2024
1 parent 0dfe0f2 commit 5325a67
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion macros/attribution_overview.sql
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ You may obtain a copy of the Snowplow Personal and Academic License Version 1.0

{% macro default__attribution_overview() %}

{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(ref('snowplow_attribution_campaign_attributions'),'cv_tstamp','cv_tstamp') %}
{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(ref('snowplow_attribution_campaign_attributions'),'cv_tstamp','cv_tstamp',true) %}

-- making sure we only include spend that is needed
with spend_with_unique_keys as (
Expand Down
2 changes: 1 addition & 1 deletion macros/paths_to_conversion.sql
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ You may obtain a copy of the Snowplow Personal and Academic License Version 1.0

{% macro default__paths_to_conversion() %}

{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(this,'cv_path_start_tstamp','cv_path_start_tstamp') %}
{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(this,'cv_path_start_tstamp','cv_path_start_tstamp',true) %}

with paths as (

Expand Down
6 changes: 3 additions & 3 deletions macros/source_checks.sql
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@

{% set conversions_source_relation = snowplow_attribution.get_relation_from_string(var('snowplow__conversions_source', '')) | default(source('derived', 'snowplow_unified_conversions')) %}
{% set conversion_path_source_relation = snowplow_attribution.get_relation_from_string(var('snowplow__conversion_path_source', '')) | default(source('derived', 'snowplow_unified_views')) %}
{%- set __, last_cv_tstamp = snowplow_utils.return_limits_from_model(conversions_source_relation,'cv_tstamp','cv_tstamp') %}
{%- set __, last_path_tstamp = snowplow_utils.return_limits_from_model(conversion_path_source_relation,'start_tstamp','start_tstamp') %}
{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(this,'cv_path_start_tstamp','cv_path_start_tstamp') %}
{%- set __, last_cv_tstamp = snowplow_utils.return_limits_from_model(conversions_source_relation,'cv_tstamp','cv_tstamp',true) %}
{%- set __, last_path_tstamp = snowplow_utils.return_limits_from_model(conversion_path_source_relation,'start_tstamp','start_tstamp',true) %}
{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(this,'cv_path_start_tstamp','cv_path_start_tstamp',true) %}

{% if is_incremental() %}
{% if last_cv_tstamp < last_processed_cv_tstamp %}
Expand Down
2 changes: 1 addition & 1 deletion models/snowplow_attribution_campaign_attributions.sql
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ You may obtain a copy of the Snowplow Personal and Academic License Version 1.0
)
}}

{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(ref('snowplow_attribution_incremental_manifest'),'last_processed_cv_tstamp','last_processed_cv_tstamp') %}
{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(ref('snowplow_attribution_incremental_manifest'),'last_processed_cv_tstamp','last_processed_cv_tstamp',true) %}


with arrays as (
Expand Down
2 changes: 1 addition & 1 deletion models/snowplow_attribution_channel_attributions.sql
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ You may obtain a copy of the Snowplow Personal and Academic License Version 1.0
snowplow_optimize = true
)
}}
{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(ref('snowplow_attribution_incremental_manifest'),'last_processed_cv_tstamp','last_processed_cv_tstamp',true) %}

{%- set __, last_processed_cv_tstamp = snowplow_utils.return_limits_from_model(ref('snowplow_attribution_incremental_manifest'),'last_processed_cv_tstamp','last_processed_cv_tstamp') %}

with arrays as (

Expand Down

0 comments on commit 5325a67

Please sign in to comment.