Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/snowplow attribution/0.2.2 #14

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

agnessnowplow
Copy link
Collaborator

Description

This release fixes a bug in the source_checks() macro that could fail if the snowplow__conversions_source or snowplow__conversion_path_source variables are overwritten. This fix should allow users to provide a schema.table or warehouse.schema.table style string reference for these sources without having to specify a dbt source in their project (similar to the default), if necessary.

Release checklist

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Checklist

  • 🎉 I have verified that these changes work locally
  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

What gif best describes this PR or how it makes you feel?

Release Only Checklist

  • I have updated the version number in all relevant places
  • I have changed the release date in the CHANGELOG.md

@agnessnowplow agnessnowplow requested a review from a team as a code owner June 19, 2024 08:53
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

@agnessnowplow agnessnowplow merged commit c484003 into main Jun 19, 2024
4 checks passed
@agnessnowplow agnessnowplow deleted the release/snowplow-attribution/0.2.2 branch June 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants