Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/snowplow ecommerce/0.5.4 #38

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Release/snowplow ecommerce/0.5.4 #38

merged 2 commits into from
Oct 4, 2023

Conversation

rlh1994
Copy link
Contributor

@rlh1994 rlh1994 commented Oct 3, 2023

Description & motivation

Fix issue with new default on end hook for non-migrated packages

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have raised a documentation PR if applicable (Link here if required)

Release Only Checklist

  • I have updated the version number in all relevant places
  • I have updated the CHANGELOG.md

@rlh1994 rlh1994 requested a review from agnessnowplow October 3, 2023 12:51
@rlh1994 rlh1994 force-pushed the release/snowplow-ecommerce/0.5.4 branch from a1756f6 to b652e59 Compare October 3, 2023 19:26
agnessnowplow
agnessnowplow approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlh1994 rlh1994 merged commit 93a60e6 into main Oct 4, 2023
4 checks passed
@rlh1994 rlh1994 deleted the release/snowplow-ecommerce/0.5.4 branch October 4, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnessnowplow agnessnowplow agnessnowplow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlh1994 @agnessnowplow