Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add base macro passthroughs #40

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Feature/add base macro passthroughs #40

merged 4 commits into from
Jan 2, 2024

Conversation

emielver
Copy link
Contributor

@emielver emielver commented Dec 7, 2023

Description & motivation

Add base macro changes

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@emielver emielver force-pushed the feature/add-base-macro-passthroughs branch from 4504d27 to 982ab44 Compare December 7, 2023 21:50
@emielver emielver force-pushed the feature/add-base-macro-passthroughs branch from 982ab44 to f67cd6c Compare December 7, 2023 22:34
@emielver emielver marked this pull request as ready for review December 12, 2023 09:17
@emielver emielver force-pushed the feature/add-base-macro-passthroughs branch from ca82222 to fdb8e87 Compare December 14, 2023 10:00
rlh1994
rlh1994 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine!

@emielver emielver force-pushed the feature/add-base-macro-passthroughs branch from 5c23b44 to 64bb172 Compare December 14, 2023 16:21
rlh1994
rlh1994 reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with what I've checked, but not had time to go into the full detail or check it runs on redshift, I'll assign Agnes to review over next week while I'm away.

agnessnowplow
agnessnowplow reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All should be good, except for redshift and the id naming (which we may change in the future only depending on whether it is a breaking change or not ).

dbt_project.yml Show resolved Hide resolved
models/base/scratch/snowplow_ecommerce_base_events_this_run.sql Show resolved Hide resolved
agnessnowplow
agnessnowplow approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlh1994 rlh1994 merged commit 66e93d6 into release/snowplow-ecommerce/0.6.0 Jan 2, 2024
4 checks passed
@rlh1994 rlh1994 deleted the feature/add-base-macro-passthroughs branch January 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlh1994 rlh1994 rlh1994 approved these changes

@agnessnowplow agnessnowplow agnessnowplow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emielver @rlh1994 @agnessnowplow