Fix/session include non ecom sessions #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnessnowplow
approved these changes
Feb 27, 2024
rlh1994
force-pushed
the
fix/session-include-non-ecom-sessions
branch
from
85edc0e to
6801d6f
Compare
georgewoodhead
changed the base branch from
main
to
release/snowplow-ecommerce/0.7.2
rlh1994
force-pushed
the
fix/session-include-non-ecom-sessions
branch
from
6801d6f to
5158ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Fixes an issue where non-ecom sessions can be added to the sessions table as they are in the manifest - swapping to an inner join on events this run prevents this. This also adds a load of sensible default values to the columns in tha table.
I also simplified the tests because I was there anyway. This has hidden the fact I added a new record to the events table that is just a page view, and that this session gets correctly discarded.
This is a breaking change, so will bump the release to actually being 0.8.0
Checklist