Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/snowplow ecommerce/0.7.2 #49

Merged
merged 5 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @snowplow/com-snowplowanalytics-engineering-datavalue-integrations
64 changes: 56 additions & 8 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,67 @@ If this is your first time contributing you will be asked to sign the Individual
If you would prefer to read this in advance of submitting your PR you can find it here https://docs.google.com/forms/d/e/1FAIpQLSd89YTDQ1XpTZbj3LpOkquV_h1Y8k9ay3iFbJsZsJrz18I23Q/viewform
-->

## Description & motivation
<!--
Describe your changes, and why you're making them.
## Description

<!-- This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. -->

## What type of PR is this? (check all applicable)

- [ ] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Related Tickets & Documents
<!--
Please use this format link issue numbers: Fixes #123
-->

## Checklist
- [ ] I have verified that these changes work locally
- [ ] I have updated the README.md (if applicable)
- [ ] I have added tests & descriptions to my models (and macros if applicable)
- [ ] I have raised a [documentation](https://github.com/snowplow/documentation) PR if applicable (Link here if required)
- [ ] ❗️ I have verified that these changes work on Redshift
- [ ] 💣 Is your change a breaking change?
- [ ] 📖 I have updated the CHANGELOG.md

### Added tests?
- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help

### Added to documentation?
- [ ] 📓 internal package docs (ymls, macros, readme, if applicable)
- [ ] 📕 I have raised a [Snowplow documentation](https://github.com/snowplow/documentation) PR if applicable (Link here if required)
- [ ] 🙅 no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?



## [optional] What gif best describes this PR or how it makes you feel?



<!-- note: PRs with deleted sections will be marked invalid -->

<!--
For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details.

For a timely review/response, please avoid force-pushing additional
commits if your PR already received reviews or comments.

Before submitting a Pull Request, please ensure you've done the following:
- 📖 Read the Contributing Guide: https://github.com/snowplow/dbt-snowplow-unified/blob/main/CONTRIBUTING.md
-->

<!--
## Release Only Checklist
- [ ] I have updated the version number in all relevant places
- [ ] I have updated the CHANGELOG.md
- [ ] I have changed the release date in the CHANGELOG.md
-->
6 changes: 3 additions & 3 deletions .github/workflows/pr_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:

steps:
- name: Check out
uses: actions/checkout@v3
uses: actions/checkout@v4

# Remove '*' and replace '.' with '_' in DBT_VERSION & set as SCHEMA_SUFFIX.
# SCHEMA_SUFFIX allows us to run multiple versions of dbt in parallel without overwriting the output tables
Expand All @@ -100,12 +100,12 @@ jobs:
echo "DEFAULT_TARGET=${{ matrix.warehouse }}" >> $GITHUB_ENV

- name: Python setup
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: "3.8.x"

- name: Pip cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ matrix.dbt_version }}-${{ matrix.warehouse }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:


steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0 # otherwise, you will failed to push refs to dest repo
# Remove '*' and replace '.' with '_' in DBT_VERSION & set as SCHEMA_SUFFIX.
Expand All @@ -82,12 +82,12 @@ jobs:
echo "DEFAULT_TARGET=${{ matrix.warehouse }}" >> $GITHUB_ENV

- name: Python setup
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: "3.8.x"

- name: Pip cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ matrix.dbt_version }}-${{ matrix.warehouse }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0 # needed to get tags

Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
steps:

- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup git
uses: oleksiyrudenko/[email protected]
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Prep release body
id: release_prep
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/set-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Run Labeler
if: success()
Expand Down
18 changes: 18 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
snowplow-ecommerce 0.8.0 (2024-02-28)
---------------------------------------
## Summary
This release makes a few core changes to the sessions table. It stops non-ecommerce sessions being added to the derived table, and provides sensible defaults for numeric and boolean columns.

## 🚨 Breaking Changes 🚨
- The sessions table now has sensible defaults (0 or false) for most numeric or boolean fields, even when that session did not have e.g. any cart events. Previously these were null.

## Fixes
- Fix issue where non-ecommerce sessions were showing in the sessions table. Note a full refresh is required to remove old sessions of this type.
- Fix an incorrect variable name in our package defaults

## Under the hood
- Simplified integration tests

## Upgrading
rlh1994 marked this conversation as resolved.
Show resolved Hide resolved
To upgrade simply bump the snowplow-ecommerce version in your `packages.yml` file. If you want to remove old sessions that shouldn't have been included, or populate nulls in the sessions table column, please do a [full refresh](https://docs.snowplow.io/docs/modeling-your-data/modeling-your-data-with-dbt/dbt-operation/full-or-partial-refreshes/#complete-refresh-of-snowplow-package).

snowplow-ecommerce 0.7.1 (2024-01-26)
---------------------------------------
## Summary
Expand Down
4 changes: 2 additions & 2 deletions dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: 'snowplow_ecommerce'

version: '0.7.1'
version: '0.8.0'
config-version: 2

require-dbt-version: [">=1.5.0", "<2.0.0"]
Expand Down Expand Up @@ -65,7 +65,7 @@ vars:
snowplow__disable_ecommerce_transactions: false
snowplow__ecommerce_event_names: ['snowplow_ecommerce_action']
snowplow__carts_passthroughs: []
snowplow__checkouts_passthroughs: []
snowplow__checkout_passthroughs: []
snowplow__products_passthroughs: []
snowplow__session_passthroughs: []
snowplow__transaction_passthroughs: []
Expand Down
Loading