Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on Redshift due to base_events_this_run using the transaction_id as partition key event if transactions are disabled (close #51) #52

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

matus-tomlein
Copy link
Contributor

Description

Fixes the error in #51 by not using the transaction_id in the partition by columns in case transactions are disabled.

What type of PR is this? (check all applicable)

  • 🐛 Bug Fix

Related Tickets & Documents

Fixes #51

Checklist

  • ❗️ I have verified that these changes work on Redshift
  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

@matus-tomlein matus-tomlein requested a review from a team as a code owner April 5, 2024 08:48
…on_id as partition key event if transactions are disabled (close #51)
@matus-tomlein matus-tomlein force-pushed the issue/51-redshift_transaction_disabled_error branch 2 times, most recently from bb93034 to 1033b06 Compare April 5, 2024 09:30
@matus-tomlein matus-tomlein force-pushed the issue/51-redshift_transaction_disabled_error branch from 1033b06 to 69e89f1 Compare April 5, 2024 09:30
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matus-tomlein matus-tomlein merged commit 13cfb4d into main Apr 5, 2024
4 checks passed
@matus-tomlein matus-tomlein deleted the issue/51-redshift_transaction_disabled_error branch April 5, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants