Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Ecommerce codebase for Spark ( Iceberg ) Support #54

Merged
merged 15 commits into from
Oct 8, 2024
Merged

Prepare Ecommerce codebase for Spark ( Iceberg ) Support #54

merged 15 commits into from
Oct 8, 2024

Conversation

ilias1111
Copy link
Contributor

@ilias1111 ilias1111 commented Oct 4, 2024 •
edited
Loading

Description

  • We change the codebase following the strategy used in unified to support Spark

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Checklist

  • ❗️ I have verified that these changes work on Redshift
  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@ilias1111 ilias1111 changed the title First push Spark RC 1 Oct 4, 2024
@ilias1111 ilias1111 changed the title Spark RC 1 Prepare Ecommerce codebase for Spark ( Iceberg ) Support Oct 7, 2024
@ilias1111 ilias1111 marked this pull request as ready for review October 7, 2024 07:47
@ilias1111 ilias1111 requested a review from a team as a code owner October 7, 2024 07:47
agnessnowplow
agnessnowplow approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilias1111 ilias1111 merged commit b63685c into main Oct 8, 2024
5 checks passed
ilias1111 added a commit that referenced this pull request Oct 9, 2024
@ilias1111
Revert "Prepare Ecommerce codebase for Spark ( Iceberg ) Support (#54)"
b81d6f0 
This reverts commit b63685c.
ilias1111 added a commit that referenced this pull request Oct 9, 2024
@ilias1111
Revert "Prepare Ecommerce codebase for Spark ( Iceberg ) Support (#54)"
4a1f577 
This reverts commit b63685c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnessnowplow agnessnowplow agnessnowplow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilias1111 @agnessnowplow