Pe 6423 support pre 103 mobile #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing the existence of seeds early on
rlh1994
force-pushed
the
release/snowplow_unified/0.4.2
branch
from
4f395e2 to
a8bd082
Compare
|
Can you rebase on the latest release branch please. Also - only if we actually have this in the integration tests I can't remember - could you remove that one of those fields from the integration tests source data (and update the downstream stuff as needed...) so that we can ensure it works as intended going forward please - if we don't have it in the tests then don't worry |
…nowplow/dbt-snowplow-unified into release/snowplow_unified/0.4.2
Oops that was a bad copy paste
ilias1111
force-pushed
the
PE-6423-Support-pre-103-mobile
branch
from
2cae9cf to
1c1dcd0
Compare
rlh1994
previously requested changes
Jun 11, 2024
rlh1994
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes this bug, by using the databricks way of accessing a JSON, which as a result if the object is not present it will return null and not an error
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #48
Checklist
Added tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?