Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/snowplow unified/0.1.2 #9

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

agnessnowplow
Copy link
Collaborator

@agnessnowplow agnessnowplow commented Nov 23, 2023

Summary

This is a patch release to fix the default browser context variable for warehouses other than redshift/postgres.

Fixes

  • Fix browser context

What type of PR is this? (check all applicable)

  • 🐛 Bug Fix

Checklist

  • 🎉 I have verified that these changes work locally
  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

Release Only Checklist

  • I have updated the version number in all relevant places
  • I have changed the release date in the CHANGELOG.md

What gif best describes this PR or how it makes you feel?

@agnessnowplow agnessnowplow force-pushed the Release/snowplow_unified/0.1.2 branch from c3c32ee to b5fc78a Compare November 23, 2023 13:14
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agnessnowplow agnessnowplow force-pushed the Release/snowplow_unified/0.1.2 branch from b5fc78a to 40ebc25 Compare November 23, 2023 14:21
@agnessnowplow agnessnowplow merged commit d736544 into main Nov 23, 2023
4 checks passed
@agnessnowplow agnessnowplow deleted the Release/snowplow_unified/0.1.2 branch November 23, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants