Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add web, fix bad link in attribution #869

Merged
merged 1 commit into from
May 1, 2024
Merged

add web, fix bad link in attribution #869

merged 1 commit into from
May 1, 2024

Conversation

rlh1994
Copy link
Contributor

@rlh1994 rlh1994 commented May 1, 2024

The json file is a copy of 1.0.0

@rlh1994 rlh1994 requested a review from matus-tomlein May 1, 2024 10:18
Copy link

netlify bot commented May 1, 2024

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit 3ff3a73
🔍 Latest deploy log https://app.netlify.com/sites/snowplow-docs/deploys/6632170c9d8e6c000826cbf2
😎 Deploy Preview https://deploy-preview-869--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -120,7 +120,7 @@
"description": "> Click the plus sign to add a new entry",
"minItems": 0,
"title": "Path Transforms",
"longDescription": "Dictionary of path transforms (and their argument, `null` if none) to perform on the full conversion path (see the transform path options in our [docs](/docs/modeling-your-data/modeling-your-data-with-dbt/package-mechanics/manifest-tables/)).",
"longDescription": "Dictionary of path transforms (and their argument, `null` if none) to perform on the full conversion path (see the transform path options in our [model docs](/docs/modeling-your-data/modeling-your-data-with-dbt/dbt-models/dbt-attribution-data-model/)).",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we supposed to add the index.md at the end to let docusaurus automatically check for broken links?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally yes, but these get rendered in a MUI table as direct links so the index.md breaks it
image

@rlh1994 rlh1994 merged commit c3ec33d into main May 1, 2024
5 checks passed
@rlh1994 rlh1994 deleted the web101 branch May 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants