Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add required field to enhance ecommerce schema #1206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffreylean
Copy link

No description provided.

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@jeffreylean
Copy link
Author

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

I signed it!

@snowplowcla
Copy link

Confirmed! @jeffreylean has signed the Contributor License Agreement. Thanks so much.

@snowplowcla snowplowcla added cla:yes and removed cla:no labels Mar 8, 2022
@paulboocock
Copy link
Contributor

Hey @jeffreylean Thanks for the PR.

Could you point me to any Google Documentation which confirms that these properties are required 100% of the time on these objects? That'd help me with considering approving this change. If there is any other motivation behind this change, then that would also be good context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants