-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add com.growthbook/experiment_viewed/jsonschema/1-0-0 #1423
base: master
Are you sure you want to change the base?
Add com.growthbook/experiment_viewed/jsonschema/1-0-0 #1423
Conversation
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
I signed it! |
Confirmed! @Auz has signed the Contributor License Agreement. Thanks so much. |
Thanks @Auz - the JSON path file is no longer needed (thankfully) so you can just PR the schema in this instance. Are |
They are not required. In Growthbook, when we query to get the list of users that are exposed to an experiment, any additional columns can be returned to be used as dimensional data. These are typically things like 'browser' or 'country', which might be readily available at the time of exposure, but harder or more expensive to query when making the reports if it requires a lot of joins. I wanted to make it possible to set additional fields, but if this is not how Snowplow does things, let me know. |
If there are more custom things it may make sense to have a part of the schema that defines an array of key value pairs (additionalProperties is tricky as we aim to infer types / column names from the schema itself). Things like browser, country, device information etc are captured automatically as part of the out of the box data (either directly or via enrichments) so hopefully shouldn't be required. |
Added GrowthBook experiment_viewed event tracking schema
Fixes #1422