Add com.delighted schemas #660
Conversation
|
@miike has signed the Software Grant and Corporate Contributor License Agreement. Thanks so much |
| "$.data.event_data.person.phone_number", | ||
| "$.data.event_data.person_properties.Browser", | ||
| "$.data.event_data.person_properties.Country", | ||
| "$.data.event_data.person_properties.Device Type", |
There was a problem hiding this comment.
I am sure there's a good reason for going with these property names, but the spaces make me very nervous. How difficult would it be to conform them to the rest of the fields, like device_type or user_agent?
There was a problem hiding this comment.
At the moment unfortunately the webhook sends these fields through with spaces so without an adapter we're stuck with the spaces.
| "description": "Responder name" | ||
| }, | ||
| "created_at": { | ||
| "type": "integer", |
There was a problem hiding this comment.
Using integers for all the timestamps is going to bleed complexity downstream into all consumers of these events. How difficult would it be to convert these in the adapter?
There was a problem hiding this comment.
I've thought about the best way to do this a bit. A large number of webhooks just give epoch timestamps rather than nicely formatted ISO datetimes. It's possible to do these quite easily in the adapter but it does mean that all webhooks with epochs require adapters.
| }, | ||
| "phone_number": { | ||
| "type": ["string", "null"], | ||
| "description": "Responser mobile phone number", |
| }, | ||
| "permalink": { | ||
| "type": "string", | ||
| "maxLength": 255, |
There was a problem hiding this comment.
Feels a bit short? Also, consider the "format": "uri" option
| }, | ||
| "user_id": { | ||
| "type": ["string", "null"], | ||
| "maxLength": 100, |
There was a problem hiding this comment.
| "ref_root" VARCHAR(255) ENCODE ZSTD NOT NULL, | ||
| "ref_tree" VARCHAR(1500) ENCODE ZSTD NOT NULL, | ||
| "ref_parent" VARCHAR(255) ENCODE ZSTD NOT NULL, | ||
| "event_data.comment" VARCHAR(512) ENCODE ZSTD, |
There was a problem hiding this comment.
I suspect a lot of these fields should be NOT NULL - to trigger this in Igluctl, you will need to add those fields into the required: [] array.
alexanderdean
changed the title
|
Hi @miike - where did we get to with this one. Did you want us to write an adapter for it? |
|
I'm part way through writing an adapter for some Vero schemas and I might tackle this one after that. |
|
If you want a AMA session with one of our data engineers on writing adapters just ping me an email! |
This PR adds two schemas for the delighted.com NPS tool