Make it possible to run ServiceSpecs with both InMemory storage and Postgres #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenes
approved these changes
Oct 9, 2023
| def sendRequestsGetResponse( | ||
| createService: Storage[IO] => HttpRoutes[IO] | ||
| )(requests: List[Request[IO]]): IO[Response[IO]] = | ||
| storageResource.use { storage => |
There was a problem hiding this comment.
nit: it seems like we can implement it using sendRequestGetState. It would reduce the deduplication.
There was a problem hiding this comment.
Yeah, it could! The number of variations of these methods across the different files was already big, so I tried to make minimal changes... We probably don’t even need both methods.
| class ValidationServiceSpec extends org.specs2.Specification { | ||
| class ValidationServiceSpec extends org.specs2.Specification with StorageAgnosticSpec with InMemoryStorageSpec { | ||
| def sendRequests(requests: List[Request[IO]]) = | ||
| sendRequestGetState(storage => ValidationService.asRoutes(storage, None, SpecHelpers.ctx, createRhoMiddleware()))( |
There was a problem hiding this comment.
nit: It seems like we don't use the state part at all. Can sendRequestsGetResponse be used instead ?
There was a problem hiding this comment.
Not in its current version as it only returns the first response :/
|
Moved to here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this to get more confidence in the changes from #137. I’ll rebase that one on this one and add more tests.