Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/6.0.3 #685

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Release/6.0.3 #685

merged 3 commits into from
Apr 19, 2024

Conversation

mscwilson
Copy link
Contributor

This patch release fixes two bugs.

The tracker will no longer crash if the app has a low version of the optional dependency InstallReferrer.

We've also added a new configuration flag, useContextResourcesScreenResolution, to fetch the default screen resolution - for the dvce_screenwidth and dvce_screenheight event properties - using a newer method.

NB: the dvce_screenwidth and dvce_screenheight screen resolution values will be different when this flag is turned on.

val networkConfig = NetworkConfiguration("https://endpoint")
val subjectConfig = SubjectConfiguration().useContextResourcesScreenResolution(true)

Snowplow.createTracker(
    context, 
    "namespace",
    networkConfig,
    subjectConfig
)

When the flag is false (default), the default resolution is fetched using a deprecated method (WindowManager). This can cause StrictMode Violations under certain conditions. Newer methods of obtaining screen size don't include the menu bar.

The mobile context entity is not affected by the flag, as it already uses the newer Android API to obtain the screen resolution.

Bug fixes


BTW, the tests are failing for API 30 due to flakiness. This problem appeared quite recently and will be addressed in a future PR.

mscwilson and others added 3 commits April 5, 2024 09:33
* Catch more errors

* Give more detailed error message

* Restore installreferrer version

* Increase sleep time in flaky tests

* Increase sleep time in flaky tests again

* Increase sleep time in flaky tests again... again
* Add SubjectConfig option

* Make flag non-optional
@mscwilson mscwilson requested a review from matus-tomlein April 18, 2024 09:47
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mscwilson mscwilson merged commit 07536ea into master Apr 19, 2024
2 of 3 checks passed
@mscwilson mscwilson deleted the release/6.0.3 branch April 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants