Fix SelfDescribingJson type to allow optional keys in type parameter (close #1203 and #1304) #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethron
force-pushed
the
PE-4998-sdjtype
branch
2 times, most recently
from
1c3417f to
851c6a7
Compare
BundleMonFiles added (6)
Total files change +102.07KB 0% Final result: ❌ View report in BundleMon website ➡️ |
matus-tomlein
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Would like to get feedback from @igneel64 on this but LGTM!
matus-tomlein
force-pushed
the
release/4.0.0
branch
from
b162da0 to
0bb7954
Compare
|
Sorry @jethron, you might need to rebase this branch as I rebased the release branch on top of master. |
matus-tomlein
changed the title
matus-tomlein
changed the title
|
@jethron can you please merge this into the release branch? I think we can move forward with this. |
jethron
added a commit
to jethron/snowplow-javascript-tracker
that referenced
this pull request
Oct 4, 2024
jethron
added a commit
to jethron/snowplow-javascript-tracker
that referenced
this pull request
Oct 4, 2024
jethron
added a commit
to jethron/snowplow-javascript-tracker
that referenced
this pull request
Oct 10, 2024
Include some Snowtype-generated code as tests.
jethron
added a commit
to jethron/snowplow-javascript-tracker
that referenced
this pull request
Oct 10, 2024
Include some Snowtype-generated code as tests.
jethron
added a commit
to jethron/snowplow-javascript-tracker
that referenced
this pull request
Oct 10, 2024
Include some Snowtype-generated code as tests.
jethron
added a commit
to jethron/snowplow-javascript-tracker
that referenced
this pull request
Oct 10, 2024
Include some Snowtype-generated code as tests.
jethron
added a commit
that referenced
this pull request
Oct 14, 2024
matus-tomlein
pushed a commit
that referenced
this pull request
Oct 25, 2024
matus-tomlein
pushed a commit
that referenced
this pull request
Oct 25, 2024
Merged
matus-tomlein
pushed a commit
that referenced
this pull request
Oct 28, 2024
matus-tomlein
pushed a commit
that referenced
this pull request
Oct 28, 2024
matus-tomlein
pushed a commit
that referenced
this pull request
Oct 28, 2024
matus-tomlein
pushed a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record<keyof T,has the unfortunate side-effect of erasing theoptionalmodifier for any properties inT, essentially mandatingRequired<T>instead of justT.Explicitly using an index type removes this erasure while still being largely compatible with the rest of the interface expressed by
Record.An index type accepting only strings is preferable over plain
{}because that allows arrays fordata, which we don't support AFAIK outside of special cases likepayload_dataandcontexts.Should fix #1203 and #1304.