Enable batching multiple events into a single POST request over buffer size if maxPostBytes setting is followed #1356
+18
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r size if maxPostBytes setting is followed
matus-tomlein
force-pushed
the
issue/batch_up_to_maxpostbytes
branch
from
fb581b2
to
7a9c12a
Compare
BundleMonFiles added (6)
Total files change +104.73KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables POST requests to contain more events than configured through
bufferSizeas long as they don't surpass themaxPostBytes.The reason for this is to send events queued up in the event store in a single POST request rather than individually. This may happen for instance if some events didn't manage to be saved on the previous page visit (or the collector was not reachable). With this feature, they should be sent in one batch request on the next visit.
It may also happen in events are tracked right after each other – if they manage to be saved to the event store before the flush function is called, they will be batched together.
The change might be useful also with issue #1355 where part of the problem could be too many requests done shortly after each other.