Add new tracker for React Native #1371
Merged
+14,235
−4,597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles added (6)
Total files change +105.62KB 0% Final result: ✅ View report in BundleMon website ➡️ |
greg-el
reviewed
Nov 8, 2024
matus-tomlein
force-pushed
the
issue/create_react_native_tracker
branch
from
7ef3a0b to
9094cb3
Compare
Mookiies
reviewed
Nov 11, 2024
…and removeTracker functions in the React Native tracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
@snowplow/react-native-trackerpackage to the monorepo.This aims to move the React Native tracker to instead of using the iOS and Android trackers as the base for the React Native tracker, to use the JavaScript tracker. The motivation for this is to:
The package will continue with the
@snowplow/react-native-trackerstarting from version 4.1 (or later). We decided for this as opposed to introducing a new package to make it more clear long term that this package replaces the old RN tracker and avoid having two RN packages. We will need to skip v3 (RN tracker is now on v2) in order to sync with the JS tracker versions.This PR implements the core of the tracker without additional features (such as session, lifecycle tracking) which will be introduced in follow up PRs. It tries to maintain the API from the RN tracker but for the
createTrackermethod, this was not possible and I think it's better to follow thenewTrackerconvention in the JS tracker. So thenewTrackermethod signature is a breaking change.I have deployed the package under the version
4.0.1-dev.1and added a very simple example app in the examples repo using it: snowplow-incubator/snowplow-javascript-tracker-examples#60 (we'll improve it over time)