Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignored label property in the startHtml5MediaTracking call #1378

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix ignored label property in the startHtml5MediaTracking call #1378

merged 1 commit into from
Nov 11, 2024
+31 −2

Conversation

matus-tomlein
Copy link
Contributor

This PR fixes an issue where the label configuration option passed to the startHtml5MediaTracking call was ignored.

@matus-tomlein matus-tomlein changed the base branch from master to release/4.0.2 November 11, 2024 15:18
greg-el
greg-el approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@greg-el greg-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 11, 2024

BundleMon

Files added (6)
Status Path Size Limits
✅ trackers/javascript-tracker/dist/sp.js
 +24.43KB 30KB / +10%
✅ libraries/browser-tracker-core/dist/index.mod
ule.js
 +23.44KB 25KB / +10%
✅ libraries/tracker-core/dist/index.module.js
 +19.4KB 20KB / +10%
✅ trackers/browser-tracker/dist/index.umd.min.j
s
 +17.32KB 20KB / +10%
✅ trackers/javascript-tracker/dist/sp.lite.js
 +17.27KB 20KB / +10%
✅ trackers/browser-tracker/dist/index.module.js
 +3.49KB 5KB / +10%

Total files change +105.35KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@matus-tomlein matus-tomlein merged commit 7e6b787 into release/4.0.2 Nov 11, 2024
3 checks passed
@matus-tomlein matus-tomlein deleted the issue/fix_ignored_label_in_media_tracking branch November 11, 2024 15:22
@matus-tomlein matus-tomlein mentioned this pull request Nov 11, 2024
Merged
matus-tomlein added a commit that referenced this pull request Nov 11, 2024
@matus-tomlein
Fix ignored label property in the startHtml5MediaTracking call (#1378)
a531208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-el greg-el greg-el approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matus-tomlein @greg-el