Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reference to object #136

Closed
wants to merge 1 commit into from
Closed

Conversation

florisluiten
Copy link

The object referenced in the PHP doc is lowercased, but the actual class is camelCased. By using the same casing, we ensure that the IDE and any static analyzer understands the reference.

The object referenced in the PHP doc is lowercased, but the actual class is camelCased. By using the same casing, we ensure that the IDE and any static analyzer understands the reference.
@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@snowplowcla snowplowcla added the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label Feb 23, 2023
@florisluiten
Copy link
Author

I'm happy to help, but I'm not comfortable singing the Contributor License Agreement. Especially since my fix is just one character.

Feel free to ignore my pull request. Perhaps you stumble on the same issue yourself, and find a solution for it.

@adatzer
Copy link
Contributor

adatzer commented Feb 24, 2023

Hello @florisluiten and thank you for your contribution!
Even if this pull request is closed, please feel free to open a GitHub issue instead, so that we can look to address this in a next release. If you want to do so, could you please add some more information on what the difference is between the expected and actual behaviour?

@florisluiten
Copy link
Author

Thanks, I've created an issue: #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants