Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on_success docstring #359

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Update on_success docstring #359

merged 7 commits into from
Aug 23, 2024

Conversation

Jack-Keene
Copy link
Contributor

No description provided.

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Apr 8, 2024
@coveralls
Copy link

coveralls commented Apr 8, 2024

Coverage Status

coverage: 95.946%. remained the same
when pulling a8b56b1 on fix/on-success-docstring
into cb7e434 on master.

snowplow_tracker/emitter_configuration.py Outdated Show resolved Hide resolved
snowplow_tracker/emitters.py Outdated Show resolved Hide resolved
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@greg-el greg-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work, Jack.

@Jack-Keene Jack-Keene merged commit 70b30f9 into master Aug 23, 2024
9 checks passed
@Jack-Keene Jack-Keene deleted the fix/on-success-docstring branch August 23, 2024 10:32
@Jack-Keene Jack-Keene restored the fix/on-success-docstring branch August 23, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants