Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typing #364

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Update typing #364

merged 1 commit into from
Aug 22, 2024

Conversation

greg-el
Copy link
Contributor

@greg-el greg-el commented Aug 21, 2024

In preparation for exposing our typing information, this PR aims to ensure that we have the correct types throughout.

@greg-el greg-el force-pushed the fix-typing branch 3 times, most recently from 6219378 to ba304b4 Compare August 21, 2024 16:43
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is super useful and great to have the check in CI!

Just a few small comments, mainly that I don't think we should change some of the optional properties in Structured

snowplow_tracker/tracker.py Outdated Show resolved Hide resolved
snowplow_tracker/tracker.py Outdated Show resolved Hide resolved
snowplow_tracker/events/structured_event.py Outdated Show resolved Hide resolved
@greg-el greg-el merged commit 69cbbcc into release/1.0.3 Aug 22, 2024
9 checks passed
@greg-el greg-el deleted the fix-typing branch August 22, 2024 12:34
@greg-el greg-el mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants