Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate good/bad sink configurations #360

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Oct 24, 2023

Old style:

streams {
      good = "good-name"
      bad = "bad-name"
      buffer {...} //shared by good and bad
      sink {...} //shared by good and bad
    }

now becomes:

streams {
      good {
        name: "good-name"
        buffer {...}
        // rest of the sink config, previously in the `sink` section...
      }
      bad {
        name: "bad-name"
        buffer {...}
        // rest of the sink config, previously in the `sink` section...
      }
    }
  • This PR is backward compatible, so the old style config is still supported.
  • Removed enabled flag from sink config which seems to be no longer used.

@pondzix pondzix force-pushed the http4s/config_refactoring branch 2 times, most recently from 80809f1 to 78b4c43 Compare October 24, 2023 08:17
@pondzix pondzix force-pushed the http4s/config_refactoring branch 2 times, most recently from 728ca3f to 16fcd00 Compare October 27, 2023 08:13
@pondzix pondzix force-pushed the http4s/config_refactoring branch from 14499ee to 96ea661 Compare October 27, 2023 11:41
@pondzix pondzix force-pushed the http4s/config_refactoring branch from 96ea661 to e5b1e2a Compare October 27, 2023 12:44
@pondzix pondzix merged commit e5b1e2a into feature/http4s Oct 27, 2023
3 checks passed
@peel peel deleted the http4s/config_refactoring branch November 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants