Minor UI changes for TransformVideoPage
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisWooyeol
requested review from
dawitfamanu,
2018JunyoungLim and
thisisWooyeol
| @@ -45,6 +46,7 @@ import androidx.compose.ui.viewinterop.AndroidView | |||
| import androidx.media3.common.MediaItem | |||
| import androidx.media3.common.Player | |||
| import androidx.media3.exoplayer.ExoPlayer | |||
| import androidx.media3.ui.AspectRatioFrameLayout.RESIZE_MODE_FILL | |||
There was a problem hiding this comment.
@peng-u-0807 혹시
import androidx.media3.ui.AspectRatioFrameLayout.RESIZE_MODE_FILL
resize mode fill과 resize mode fit중에 어떤 게 나을까요? 정방형 영상을 보니 너무 위아래로 늘어난 게 아닌가 싶어서 여쭙습니다!
There was a problem hiding this comment.
@thisisWooyeol 안그래도 영상이 좀 이상하게 보이는 것 같아 확인해보니 원하는 결과를 얻으려면AspectRatioFramLayout.RESIZE_MODE_ZOOM을 사용해야할 것 같아 ZOOM으로 수정했습니다!
thisisWooyeol
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정사항