feat: emoji pagination #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2018JunyoungLim
requested review from
dawitfamanu,
peng-u-0807,
thisisWooyeol and
yangchanhk98
peng-u-0807
reviewed
Nov 23, 2023
| import com.goliath.emojihub.models.EmojiDto | ||
| import javax.inject.Inject | ||
|
|
||
| class EmojiPagingSource @Inject constructor( |
There was a problem hiding this comment.
사소하지만 여기 whitespace 빼주시면 좋을 것 같습니다!
| } | ||
| return listOf() | ||
| override suspend fun fetchEmojiList(): Flow<PagingData<EmojiDto>> { | ||
| // try { |
There was a problem hiding this comment.
여기 뿐만 아니라 다른 파일에 대해서도 공통적으로 남기는 코멘트인데 더이상 사용하지 않을 코드에 대해서는 주석보다는 아예 삭제 부탁드립니다!
peng-u-0807
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정사항