Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/android view reaction bottomsheet #77

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Feat/android view reaction bottomsheet #77

merged 14 commits into from
Nov 30, 2023

Conversation

dawitfamanu
Copy link
Contributor

@dawitfamanu dawitfamanu commented Nov 28, 2023 •
edited
Loading

Changes:

  • BottomSheet controller implemented
  • BottomSheet shown for View Reaction and Add Reaction buttons.

TODO:

  • fetch user's created and saved emojis
  • fetch reaction emojis under posts
  • fetch up-to three unicodes for display on ViewReaction button

@dawitfamanu dawitfamanu self-assigned this Nov 28, 2023
yangchanhk98
yangchanhk98 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@yangchanhk98 yangchanhk98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawitfamanu 다윗님 컴파일 오류 뜨는 것 같은데 확인 부탁드려요
image

@dawitfamanu dawitfamanu marked this pull request as draft November 28, 2023 10:41
@dawitfamanu dawitfamanu marked this pull request as ready for review November 28, 2023 11:43
@thisisWooyeol
Copy link
Contributor

@yangchanhk98 unit test 오류 수정했습니다.

yangchanhk98
yangchanhk98 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@yangchanhk98 yangchanhk98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 머지할게요

@yangchanhk98 yangchanhk98 merged commit 76648f7 into develop Nov 30, 2023
2 checks passed
@thisisWooyeol thisisWooyeol deleted the feat/android-view-reaction-bottomsheet branch November 30, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisWooyeol thisisWooyeol thisisWooyeol approved these changes

@yangchanhk98 yangchanhk98 yangchanhk98 approved these changes

@peng-u-0807 peng-u-0807 Awaiting requested review from peng-u-0807

@2018JunyoungLim 2018JunyoungLim Awaiting requested review from 2018JunyoungLim

Assignees

@dawitfamanu dawitfamanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dawitfamanu @thisisWooyeol @yangchanhk98 @peng-u-0807